My intent is to allow stop (square icon) to stop the maslow and gcode job running, but not require a restart/power off. while abort (“not” icon) will act like the stop does now (eStop).
I’ll probably pull request this soon, no matter what, to get the functionality out there, but I can change it if the iconography or position of this is not ideal, and would love community feedback, Realizing EVERYone has opinions on user interface, and its always the user interface’s fault for everything
currently the maslow_estop is something specific to maslow.
fluidNC has ! to halt all movement, and also a door open signal that freezes
everything.
it would probably be best to verify that they stop all movement (including not
letting the pid loop continue, so it may require inserting a test inside the
loop) and then switch to using those instead of a maslow-proprietary command.
(fluidnc already recovers from those events happening)
How about the word ‘ABORT’ instead of the ‘forbidden’ icon ? Using the forbidden icon is confusing to me.
In industrial robotics, this is called ‘Emergency Motion Off’, or EMO, which stops motion but does not remove power from the controller, and is different from ‘Emergency Power Off’ or EPO, which removes power from everything. EMO and EPO would probably be confusing to many people, so best not to use them.
Looks like the current javascript/html code is already calling ! on pause, but also this code is a bit confusing in that there is code in here to set the buttons up based on grbl state, but it does not appear to be used right now. I’m going to take some time to figure this out, clean up a bit and test a lot before I pr.
The actual change to “stop” to make it call ! is simple, and I’ve confirmed it works well, but I think the UI state is not reseting “pause” to be “resume” (~) any more, so I’m trying to unwind that right now.
The more I look at and use this, the more I want to rearrange things. I also have accidentally hit the wrong thing a few times on my little tablet. The files dropdown is something I can barely get my fat finger to click and it also is close to that “bad” button.
Current thought: 3 buttons “Play” and “stop” and “abort”. When the job is running, “play” becomes “pause”. when paused or stopped it becomes “play” again. When stop is hit, it just stops the machine and the job. No reboot required.
When abort is hit, it is like hitting stop today, but it will also stop motion and require reboot.
It looks to me like this is growing to be a slightly bigger job than I was thinking so I may be a bit…
Also, no shade intended on anyone that worked on this before me! It works fine “in the lab” (i.e. on my computer) but some of this is difficult on my small device, which is what I’ll run jobs on mostly.
I’m not a fan of icons. As a practical matter, all the documentation and help is in English, so someone who can’t work their way through it is not going to be helped by icons, and too many icons only work if you know what they mean (and it’s a lot harder to say ‘press the button with the four arrows pointing away from a circle in the center’ than ‘press extend’)
Plus people will confuse the calipers with a pipe wrench. It took me a minute to realize that those were calipers and meant ‘calibrate’. I vote for words too.
I’m in favor of both. English speakers are, I believe, the largest part of the user base, so might as well cater to them. The icons will help the non-English speakers figure it out. Eventually we can have options to change the words to other languages.
Plus people will confuse the calipers with a pipe wrench. It took me a minute to realize that those were calipers and meant ‘calibrate’. I vote for words too.
I didn’t catch on that they were calipers until you posted it, I thought it was
a wrench as well.
That is exactly the feedback I expected, thanks! Spot on that we already went too far down the english only path here. I’ll add words to the icons I already have and leave the setup dialog alone.
Note too that for me, I have little ego about code, so keep the comments coming as I learn this project!
If I search the web for images of “calibrate icon” I see a lot of target-like arrangements. Maybe that would be more obvious. Of course calibration is not a word used in everyday conversation, so it’s not surprising that we’re having trouble coming up with an icon.
The UI looks great. I do prefer words but maybe a combo could work.
Once we get the bugs worked out and we get the capability to start and stop the router with a relay. It would be nice to have a manual Router On and Off buttons on the control UI. I used this function quite a bit on the old maslow.
so I may be a bit…
That is exactly the feedback I expected, thanks! Spot on that we already went too far down the english only path here. I’ll add words to the icons I already have and leave the setup dialog alone.