FluidNC from 1.05 renaming bug on Android Chrome

Quite amusing (because I was able to work around it) bug.

I’ve not fully checked I can repro from a fresh flash but I believe all I did was:

  • Full Flash 1.05 from Windows on top of a fresh from factory 4.1 board.
  • Try config and have it fail (don’t think it’s related).
  • Power cycle
  • Attempt to rename / modify files on Android 12 running Chrome 136..0.7103.87 connecting via Maslow-self-hotspot.

Soooooo when I did this, if I tried to rename a file (ie maslow.yaml → maslow_bak.yaml), it instead renamed it to ‘Ok.js’. File itself was unchanged so it appears it’s pulling the string for the button name rather than the text field.

And I tried creating a folder and canceling that and it called it ‘Cancel’ (maybe .js I forgot to check).

I wonder if it’s related to:

I wasn’t able to delete the folder, but I also bailed from trying to work around it on my phone at that point.

I bought it in, and connecting to my laptop inside I was able to upload a new maslow.yaml, so I went off to keep trying at that point.

I’ll try to find some time to look at the code see if I can find where it’s doing it once i’ve got myself set up building the source (unless someone can spot it easily).

1 Like

:joy:
:joy:
:joy:

That is a really good one, I will see if I can replicate that :grin:

Yep, it’s definitely one of the more entertaining bugs i’ve seen in my time :rofl:

1 Like

I have run across this and have been able to confirm using window 11 - Chrome

2 Likes

I am able to replicate this too using the edit file name tool:

It seems like the culprit is these two lines here:

const creditsDlgCancel = () => closeModal("cancel");
const creditsDlgClose = () => closeModal("Ok");

We should be calling the closeInputModal function instead.

Here is a fixed index.html file. The fixes will also be in the next release.

index.html.gz (117.4 KB)

1 Like