Yes exactly. I can see it being a problem, especially if it’s not centred correctly within the anchors.
@dlang if you have a chance will you check to see if everything which should be included in the main branch is currently included in the main branch? It seems like maybe something didn’t make it into the PR
Bar wrote:
@dlang if you have a chance will you check to see if everything which should be included in the main branch is currently included in the main branch? It seems like maybe something didn’t make it into the PR
I will dig into this late today
David Lang
Bar wrote:
@dlang if you have a chance will you check to see if everything which should
be included in the main branch is currently included in the main branch? It
seems like maybe something didn’t make it into the PR
I’m about to run out the door, can someone post an example of a file where the
bounding box is not working correctly? (this set of fixes was for mishandling
G2/G3 commands)
David Lang
Bar wrote:
@dlang if you have a chance will you check to see if everything which should
be included in the main branch is currently included in the main branch? It
seems like maybe something didn’t make it into the PR
yes, it looks like that PR didn’t merge correctly, I’ve got copilot trying to
investigate why
David Lang
David Lang wrote:
@dlang if you have a chance will you check to see if everything which
should be included in the main branch is currently included in the main
branch? It seems like maybe something didn’t make it into the PRyes, it looks like that PR didn’t merge correctly, I’ve got copilot trying to
investigate why
copilot got stupid, so I’m trying a new issue. We may need to revert that merge
and try again.
David Lang
David Lang wrote:
@dlang if you have a chance will you check to see if everything which
should be included in the main branch is currently included in the main
branch? It seems like maybe something didn’t make it into the PRyes, it looks like that PR didn’t merge correctly, I’ve got copilot trying
to investigate whycopilot got stupid, so I’m trying a new issue. We may need to revert that
merge and try again.
found the problem, PR #618 broke things via #624 (which attempted to resolve
conflicts, but undid a bunch of stuff)
copilot is getting stupid again and assuming that I only care about the fixes in
592 rather than all the changes from 608, I may need to do another issue to get
it to do something sane. manual fixes from the breadcrumbs it’s providing may be
needed.
currently working on #655
David Lang
firmware-package.zip (1.3 MB)
try this version (from PR #655) it claims to have fixed the bad merge. I’ve got copilot running tests now, but I have to hit the road and may not be able to follow up for several hours.
copilot validated all the tests, but people experiencing the issue should try the version I posted a few min ago.
I am trying now, Trace boundary looks fine. I am running a Find Anchors to confirm that works.
Confirmation that Find anchors works, still wide and requires support at end of work area. Would probably stay without support but you have to be sure work surface is centered accurately and watch it while working. It does tend to tilt on when doing the final width runs with Maslow projecting over the end.
Running a test works well, interrupted with stop and loaded new file, no problem encountered
I need to cut some signs for my niece this week. What build is best currently stable?
V1,15 is good, the newer test version is also good and has some nice additional features. I would recommend both. If you are using 1.15 be aware the Trace Boundaries function may be too big and run the Maslow over the edge of work area in some instances..
@dlang Any follow up on this? I’d love to get 1.16 out and I think this is the last thing that we need to get in there
I’m away for week or so.tried this and it seems good
Bar wrote:
@dlang Any follow up on this? I’d love to get 1.16 out and I think this is the last thing that we need to get in there
Yes, several people have tried it and it does fix the issue.
David Lang
firmware-package.zip (1.3 MB)
Please give this a try, the changes in this should not change the behavior compared to v1.16, but it does a lot of code cleanup (replacing fooTL with foo(tl) in both arrays and functions and eliminating code duplication with loops)
I put in a request to save Maslow position after Release Tension and Power Off. You have to let the Maslow settle for a few seconds after moving, before Release Tension, but you can then Power Off the Maslow. On resumption, the Maslow should start in status Extended, and on Apply Tension should go to Ready To Cut status.
[Save belt positions in EXTENDEDOUT state to prevent position loss on power cycle] (Save belt positions in EXTENDEDOUT state to prevent position loss on power cycle by Copilot · Pull Request #683 · MaslowCNC/Maslow_4 · GitHub)
This is a firmware only update. I have done some initial testing and would appreciate others input.
firmware.bin (1.9 MB)
firmware-package.zip (1.3 MB)
Noticed the Boundaries overstate the size of the cut, at least with complex shapes.
I’d prefer just a rectangular box around graphic, Easier to see and faster to test dimensions prior to cutting.
I find that I’m pretty often cutting parts that aren’t very rectangular out of scrap pieces so I really like being able to trace the actual parts boundary instead of just the bounding rectangle.
Do we want to visualize the blue bounding box at all? I love being able to trace it, but I don’t know that the blue visualization is giving us much other than making the UI a little harder to understand
