I can’t remove old index or maslow.yaml files, as they are undefined.htm. I don’t think I can upload new ones either.
bar
March 26, 2025, 11:14pm
42
You can always wipe everything with the USB cable approach
Tore
March 27, 2025, 7:55am
43
Uploading seems to work fine. I uploaded the 0.88 version of index.html.gz via 1.01 webgui. After that I could download the other files.
1 Like
Tore
March 28, 2025, 11:33pm
44
I did our first cut today with FW 1.01 and index.html.gz 0.88.
It was just a 200mmx200mm square, but I’m very happy to see it moving AND cutting!
The sound is horrible, but running a 1/8" corn-cob cutter in soft wood is not going to produce any sweet music at 12000rpm I’d guess.
It was the only one I had available, and I just couldn’t wait any longer. I’m hoping to get my real cutters tomorrow, but most likely they will arrive on monday.
Keep your cat away and turn the volume down
A test done with a flat mill shows that the vertical axis is more accurate than the horizontal.
I also tested jogging 50mm in all directions with the same bit.
Not sure why the bottom line isn’t straight. It might be because the material has a little bump there, combined with a Dremel bit that’s really not meant for this.
1 Like
md8n
March 29, 2025, 3:18am
45
I’ve had some time to have a crack at the preferences dialog problems - It hasn’t seen a lot of attention from me, and … well … the code that’s in there is a desiccated old lump of
So now it’s had a bit of attention. And here’s a new index.html.gz (116.7 KB) for you to try out, depending on your level of bravery.
It will show up as v1.02, but your fluidNC version will remain the same of course. Obviously this ain’t coming via @bar , but he suggested I fling it out there for you all to try…
Some ai thingo wrote this about it
Maslow-Main
← md8n:get_checked
## Walkthrough
The pull request refactors UI event handling and state managemen… t across multiple files. Checkbox state manipulation is now centralized through helper functions, replacing direct property access. New default preferences and utility functions have been introduced for managing user settings, and the preferences dialog has been restructured with cleaner event handling and updated element IDs. Additionally, minor updates include a version bump and refactored tab switching logic to improve code clarity and maintainability.
## Changes
| File(s) | Summary of Changes |
|---------|--------------------|
| `www/js/controls.js`, `www/js/util.js` | Refactored checkbox state management: replaced direct manipulation with `setChecked`/`getChecked` in `controls.js` and added `setCheckedDefault` in `util.js`; updated internal logic in `setDisplay`. |
| `www/js/prefDefs.js`, `www/js/prefUtils.js`, `www/js/preferencesdlg.js`, `www/sub/preferencesdlg.html` | Enhanced preferences management: introduced a new default preferences variable, added several utility functions for settings comparison and UI toggling, removed hardcoded defaults, restructured event handling, and updated HTML elements with new IDs and attributes. |
| `www/js/tablet.js`, `www/js/tabs.js` | Updated version number in `tablet.js` and refactored the `opentab` function in `tabs.js` using modern loops and strict equality checks for cleaner UI control. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant U as User
participant PD as Preferences Dialog
participant SP as savingPreferences
participant S as SavePreferences
participant GP as getPreferencesForSave
U->>PD: Click "Save" button
PD->>SP: Trigger save event
SP->>S: Call SavePreferences(false)
S->>GP: Prepare preferences for saving
GP-->>S: Return constructed preferences
S-->>SP: Complete saving process
SP-->>PD: Update dialog/UI
```
```mermaid
sequenceDiagram
participant U as User
participant T as Tab Controller (opentab)
participant E as displayNone
U->>T: Click on tab
T->>T: Loop through tab contents (for...of)
T->>E: Hide each tab content via displayNone()
T->>T: Remove "active" class from tablinks
T->>T: Activate selected tab and dispatch activateEvent
```
## Poem
> I’m a rabbit hopping through fields of code,
> Where checkboxes now dance by a solid mode.
> Preferences bloom like carrots in spring,
> Each function a delight, making the UI sing.
> With refactored hops and tidy new art,
> CodeRabbit grins, proud in every part.
> Happy bytes and bounces all around!
<details>
<summary>✨ Finishing Touches</summary>
- [ ] 📝 Generate Docstrings
</details>
---
<details>
<summary>🪧 Tips</summary>
### Chat
There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=BarbourSmith/ESP3D-WEBUI&utm_content=122):
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- `I pushed a fix in commit <commit_id>, please review it.`
- `Generate unit testing code for this file.`
- `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
- `@coderabbitai generate unit testing code for this file.`
- `@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
- `@coderabbitai read src/utils.ts and generate unit testing code.`
- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
- `@coderabbitai help me debug CodeRabbit configuration file.`
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
### CodeRabbit Commands (Invoked using PR comments)
- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai plan` to trigger planning for file edits and PR creation.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.
### Other keywords and placeholders
- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.
### CodeRabbit Configuration File (`.coderabbit.yaml`)
- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`
### Documentation and Community
- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
</details>
1 Like
MrN808
March 29, 2025, 6:37am
46
Mahalo for your work!
All I can test at the moment is the “preferences” issue, and in my experience, the preferences set don’t persist. Not a biggie for me at the moment, but wanted to share the datum.
Mahalo,
1 Like
md8n
March 29, 2025, 12:07pm
47
They should with this version
1 Like
MrN808
March 29, 2025, 4:39pm
48
I uploaded this version to my Maslow 4, and the startup identifies the index.html.gz as 1.02.
1 Like
MrN808
March 29, 2025, 6:49pm
49
As I continue to explore…I can’t download files, either. When I click the download button (for, for example, the maslow.yaml file) in the Manage local files popup, a new browser tab opens, displaying as follows:
Looks like there’s a problem with this site
http://maslow.lan/undefined might have a temporary problem or it could have moved.
Error code: 404 Not Found
The site could be temporarily unavailable or too busy. Try again in a few moments.
Just to minimize variables, I reinstalled v1.01 from scratch using sh full-install.sh , then uploaded the above index.html.gz in the Manage local files pop-up. Afterward, the file size of index.html.gz on the Maslow checked out at 119,512 bites, the same as the download size.
1 Like
md8n
March 29, 2025, 11:49pm
50
MrN808:
As I continue to explore…I can’t download files, either. When I click the download button (for, for example, the maslow.yaml file) in the Manage local files popup, a new browser tab opens, displaying as follows:
Thanks for the feedback. I didn’t touch that bit of code at all. But I’ll check what might be going on
2 Likes
MrN808
March 30, 2025, 12:27am
51
I appreciate everything you do for this community!
1 Like
md8n
March 30, 2025, 12:37am
52
index.html.gz (116.7 KB)
Thanks so much for the feedback, it’s great having someone who can describe a bug they’ve experienced.
Above is version 1.02.01
There were bugs in the SPIFFs dialog (File System dialog) that impacted many of the functions, especially those related to individual files. Hopefully I’ve fixed all of them.
2 Likes
MrN808
March 30, 2025, 1:01am
53
In my world, the downloads are working as expected again with index.html.gz v1.02.01. My preferences aren’t persisting, but I wonder if that’s some odd idiosyncrasy of my machine (I don’t know how that could be, but I haven’t heard anyone else talking about it). I’ve had that issue since v1.0.
I switch off Connection monitoring , turn on Show probe panel , and set Touch plate thickness to 0. I save the changes, but if I either refresh the browser or restart the machine, it goes right back to the default.
1 Like
md8n
March 30, 2025, 1:03am
54
MrN808:
I switch off Connection monitoring , turn on Show probe panel , and set Touch plate thickness to 0. I save the changes, but if I either refresh the browser or restart the machine, it goes right back to the default.
Thanks, I’ll give that a test.
md8n
March 30, 2025, 1:10am
55
MrN808:
I switch off Connection monitoring , turn on Show probe panel , and set Touch plate thickness to 0. I save the changes, but if I either refresh the browser or restart the machine, it goes right back to the default.
So the file is being successfully saved. If you go to the file dialog you can download preferences.json and confirm the updated values.
But after a refresh of the browser it isn’t loading the preferences.json successfully as part of the start up process. So you get the default values…
1 Like
MrN808
March 30, 2025, 1:28am
56
md8n:
So the file is being successfully saved. If you go to the file dialog you can download preferences.json and confirm the updated values.
But after a refresh of the browser it isn’t loading the preferences.json successfully as part of the start up process. So you get the default values…
Thank you! That checks out and makes me feel a little less singled out by the universe.
1 Like
md8n
March 30, 2025, 1:28am
57
So the reload of preferences.json
at app startup (e.g. browser refresh) was caused by a single superfluous character, which I’ve now deleted.
Here’s 1.02.02
index.html.gz (116.7 KB)
2 Likes
MrN808
March 30, 2025, 1:31am
58
Fantastic! That resolved it! Mahalo nui loa!
2 Likes
md8n
March 30, 2025, 1:44am
59
MrN808:
Mahalo nui loa
Nada.
Obrigadu barak ba ita-nia koko no informasaun. Ne’e ajuda hau to’o haree problema.
2 Likes
md8n
March 30, 2025, 3:58am
60
@bar - I think this PR is good to merge now.
1 Like